Review Request 124037: Allow to cancel critical battery timer

Kai Uwe Broulik kde at privat.broulik.de
Mon Jun 8 17:30:14 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124037/
-----------------------------------------------------------

(Updated June 8, 2015, 5:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Solid and KDE Usability.


Changes
-------

Submitted with commit 9bb399ef24a3323788ef3084f2e404c8831f251b by Kai Uwe Broulik to branch master.


Repository: powerdevil


Description
-------

To prevent David from eventually breaking his bones tumbling down the stairs rushing for his AC adapter, this adds a "Cancel" button to the battery critical notification that allows to cancel the timeout for automatic suspend/shutdown.


Diffs
-----

  daemon/powerdevilcore.h 50e6a50 
  daemon/powerdevilcore.cpp e90a960 

Diff: https://git.reviewboard.kde.org/r/124037/diff/


Testing
-------

Got a "Cancel" button only when it was configured to do something, clicking the button from both popup and history cancelled the timeout. (Unfortunately the notification doesn't fit into the popup at all now)


File Attachments
----------------

Notification with close button
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/07/f99c0164-4436-462f-974b-ddc5df0ce500__powerdevilcanceltimeout.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150608/573f56ec/attachment.html>


More information about the Plasma-devel mailing list