Review Request 124004: Add week numbers to calendar - Part 1

[Martin Klapetek]

> On June 4, 2015, 12:14 p.m., Aleix Pol Gonzalez wrote:
> > You can use QJSArray. In fact it's quite faster as I think it's what V4 uses internally, so no casting happens.
> 
> Martin Klapetek wrote:
>     There is no QJSArray; you mean QJSValue? Or QJsonArray?
> 
> Aleix Pol Gonzalez wrote:
>     QJsonArray I meant.
>     We already use it in some places, in fact.
> 
> Kai Uwe Broulik wrote:
>     I once tried to investigate that. I don't think QML can directly handle QJsonArray, it's just that you can convert them to QVariantList and that QML understands.

So is it worth using for this simple 5 elements array?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/#review81169
-----------------------------------------------------------


On June 4, 2015, 7:48 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124004/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> One of the most requested features for Plasma5. The backend is all there*, it just needs the frontend part. Optional, defaults to off.
> 
> *Somehow the Repeater { model: } does not like QList<int>, it just doesn't show anything while QStringList works just fine. Any ideas on that?
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
> 
> Diff: https://git.reviewboard.kde.org/r/124004/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150604/ea2caffd/attachment.html>