Review Request 124004: Add week numbers to calendar - Part 1

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/
-----------------------------------------------------------

(Updated June 4, 2015, 7:48 p.m.)


Review request for Plasma.


Changes
-------

Fix all the comments except the QJSArray, waiting on clarification on that one.


Repository: plasma-framework


Description
-------

One of the most requested features for Plasma5. The backend is all there*, it just needs the frontend part. Optional, defaults to off.

*Somehow the Repeater { model: } does not like QList<int>, it just doesn't show anything while QStringList works just fine. Any ideas on that?


Diffs (updated)
-----

  src/declarativeimports/calendar/calendar.h ea20bf5 
  src/declarativeimports/calendar/calendar.cpp a766acb 
  src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
  src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 

Diff: https://git.reviewboard.kde.org/r/124004/diff/


Testing
-------


File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150604/5abf0705/attachment.html>