Review Request 124004: Add week numbers to calendar - Part 1

[Martin Klapetek]

> On June 4, 2015, 12:07 p.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/calendar/calendar.h, line 56
> > <https://git.reviewboard.kde.org/r/124004/diff/1/?file=378752#file378752line56>
> >
> >     Oh, and I'd say you should use QVariantList so you can still store numbers and not break the API by suddenly returning a list of strings. (?)

This is so far unused API (afaik), so that should be fine?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/#review81167
-----------------------------------------------------------


On June 4, 2015, 11:53 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124004/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 11:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> One of the most requested features for Plasma5. The backend is all there*, it just needs the frontend part. Optional, defaults to off.
> 
> *Somehow the Repeater { model: } does not like QList<int>, it just doesn't show anything while QStringList works just fine. Any ideas on that?
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
> 
> Diff: https://git.reviewboard.kde.org/r/124004/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150604/7f2226de/attachment-0001.html>