Review Request 123999: Don't crash in XRandrBrightness if not on xcb
Sebastian Kügler
sebas at kde.org
Thu Jun 4 01:39:00 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123999/#review81154
-----------------------------------------------------------
Looks good to me. I'll leave the honours to Kai Uwe.
- Sebastian Kügler
On June 3, 2015, 11:08 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123999/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 11:08 p.m.)
>
>
> Review request for Plasma, Solid and Kai Uwe Broulik.
>
>
> Repository: powerdevil
>
>
> Description
> -------
>
> On e.g. platform wayland XRandrBrightness shouldn't do anything. By
> skipping the initialization the isSupported returns false.
>
>
> Diffs
> -----
>
> daemon/backends/upower/xrandrbrightness.cpp f1cd5a5a0958e72aea87bfda88642faaa696f850
>
> Diff: https://git.reviewboard.kde.org/r/123999/diff/
>
>
> Testing
> -------
>
> kded5 no longer crashes when initializing powerdevil when running with platform wayland.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150604/c3a9e2ab/attachment.html>
More information about the Plasma-devel
mailing list