Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir
Mark Gaiser
markg85 at gmail.com
Fri Jul 31 13:25:48 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124534/#review83235
-----------------------------------------------------------
You even added categorized logging!
Big +1, again :)
Consider it a ship it if nobody does (and doesn't complain) in the next few days.
- Mark Gaiser
On jul 31, 2015, 1:03 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124534/
> -----------------------------------------------------------
>
> (Updated jul 31, 2015, 1:03 p.m.)
>
>
> Review request for Plasma and Vishesh Handa.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Commit f913e251fe6 removed this, due to a porting bug: both klauncher
> (XDG autostart using .desktop files) and ksmserver (kde-specific scripts)
> were ported to look at the same directory (~/.config/autostart),
> leading to double autostart. The right fix, however, is to use
> a different directory for scripts, I called it ~/.config/autostart-scripts.
>
> BUG: 338242
> REVIEW: 124534
>
>
> Diffs
> -----
>
> ksmserver/server.h 2176aa1c9a6505773b61354dee6fd547fdf5841e
> ksmserver/startup.cpp 531e88b4257901e890f16c23761d2c0aa538d524
>
> Diff: https://git.reviewboard.kde.org/r/124534/diff/
>
>
> Testing
> -------
>
> Logged out and back in many times :)
>
> My autostart folder got copied correctly, including symlinks
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150731/ea138bfc/attachment.html>
More information about the Plasma-devel
mailing list