Review Request 124547: Use the same behavior of MouseArea to map coords of filtered child events

Marco Martin notmart at gmail.com
Fri Jul 31 13:05:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124547/
-----------------------------------------------------------

Review request for Plasma.


Repository: kdeclarative


Description
-------

filtered mouse events and mouse events will have coordinates mapped differently, having a touch and a mouse click on the same place arriving with two different coordinates in the event filter. for more details see
https://bugreports.qt.io/browse/QTBUG-46761
https://codereview.qt-project.org/#/c/114424/
It's unlikely this behavior to change in Qt as a change may have strange sideeffects in current user code.

What we would want is coordinates arriving all mapped as they were local coordinates of the MouseEventListener.
This makes it do like MouseArea, that maps from event->windowPos() , making it actually bypassing the wrong pos() of the filtered event.

The behavior for mouse clicks should be completely the same, but this should fix touch event coordinates.


Diffs
-----

  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp ffbaf42 

Diff: https://git.reviewboard.kde.org/r/124547/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150731/74ff808a/attachment.html>


More information about the Plasma-devel mailing list