Review Request 124536: Expose immutable config options in ConfigPropertyMap

Marco Martin notmart at gmail.com
Fri Jul 31 12:58:23 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124536/#review83232
-----------------------------------------------------------



src/kdeclarative/configpropertymap.cpp (line 76)
<https://git.reviewboard.kde.org/r/124536/#comment57474>

    this actually duplicates the same keys twice


- Marco Martin


On July 30, 2015, 8:10 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124536/
> -----------------------------------------------------------
> 
> (Updated July 30, 2015, 8:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This exposes a hash of immutable config options through the "immutables" property. I tried adding a Q_INVOKABLE which would be much nicer but me and Dan tried everything but couldn't make it work.
> 
> 
> Diffs
> -----
> 
>   src/kdeclarative/configpropertymap.cpp 93c49a3 
> 
> Diff: https://git.reviewboard.kde.org/r/124536/diff/
> 
> 
> Testing
> -------
> 
> Works, I can not grey out immutable config options in Plasma
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150731/9a9d5eca/attachment.html>


More information about the Plasma-devel mailing list