Review Request 124543: Don't horizontally shift dialog

Marco Martin notmart at gmail.com
Fri Jul 31 12:52:42 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124543/#review83230
-----------------------------------------------------------


did you test it with left and right edge panels?

- Marco Martin


On July 31, 2015, 8:57 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124543/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 8:57 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> When placing an applet on the far right corner of the screen (eg. analog clock), its popup would appear diagonally shifted to the left rather than at the screen edge.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp 6770c1a 
> 
> Diff: https://git.reviewboard.kde.org/r/124543/diff/
> 
> 
> Testing
> -------
> 
> It no longer does that but I don't know what other implications this voodoo has. On the other hand, the dialogs usually pop out at the top or bottom (for free floating) and this stuff isn't touched, just the horizontal shifting removed.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150731/342de5ec/attachment.html>


More information about the Plasma-devel mailing list