Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

[Martin Klapetek]

> On July 30, 2015, 8:42 p.m., Mark Gaiser wrote:
> > ksmserver/startup.cpp, lines 504-518
> > <https://git.reviewboard.kde.org/r/124534/diff/1/?file=388761#file388761line504>
> >
> >     You're mixing coding styles here. This looks different (more use of spaces) then the above chunk. Perhaps run AStyle with kf5 settings over this?
> 
> David Faure wrote:
>     The rest of the file doesn't follow the kf5 coding style either. This is plasma-workspace, I don't know if there's a coding style in place, actually.

> This is plasma-workspace, I don't know if there's a coding style in place, actually.

It should be the kf5 one preferrably, however ksmserver is an old code and most likely was not adjusted while ported to kf5. New code is usually preferred to come with the new style though.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124534/#review83190
-----------------------------------------------------------


On July 30, 2015, 2:48 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124534/
> -----------------------------------------------------------
> 
> (Updated July 30, 2015, 2:48 p.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Commit f913e251fe6 removed this, due to a porting bug: both klauncher
> (XDG autostart using .desktop files) and ksmserver (kde-specific scripts)
> were ported to look at the same directory (~/.config/autostart),
> leading to double autostart. The right fix, however, is to use
> a different directory for scripts, I called it ~/.config/autostart-scripts.
> 
> BUG: 338242
> 
> 
> Diffs
> -----
> 
>   ksmserver/server.h 2176aa1c9a6505773b61354dee6fd547fdf5841e 
>   ksmserver/startup.cpp 531e88b4257901e890f16c23761d2c0aa538d524 
> 
> Diff: https://git.reviewboard.kde.org/r/124534/diff/
> 
> 
> Testing
> -------
> 
> Logged out and back in many times :)
> 
> My autostart folder got copied correctly, including symlinks
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150730/b9645676/attachment-0001.html>