Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124534/#review83190
-----------------------------------------------------------



ksmserver/startup.cpp (lines 461 - 500)
<https://git.reviewboard.kde.org/r/124534/#comment57449>

    This chunk seems to be very self contained and not even running the autostart. It's merely copying kde 4.x.x files to the new 5.x.x place.
    
    Perhaps move it to a function of it's own. "migrateKde4Autostart()" or something alike?



ksmserver/startup.cpp (lines 502 - 516)
<https://git.reviewboard.kde.org/r/124534/#comment57450>

    You're mixing coding styles here. This looks different (more use of spaces) then the above chunk. Perhaps run AStyle with kf5 settings over this?


- Mark Gaiser


On jul 30, 2015, 12:48 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124534/
> -----------------------------------------------------------
> 
> (Updated jul 30, 2015, 12:48 p.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Commit f913e251fe6 removed this, due to a porting bug: both klauncher
> (XDG autostart using .desktop files) and ksmserver (kde-specific scripts)
> were ported to look at the same directory (~/.config/autostart),
> leading to double autostart. The right fix, however, is to use
> a different directory for scripts, I called it ~/.config/autostart-scripts.
> 
> BUG: 338242
> 
> 
> Diffs
> -----
> 
>   ksmserver/server.h 2176aa1c9a6505773b61354dee6fd547fdf5841e 
>   ksmserver/startup.cpp 531e88b4257901e890f16c23761d2c0aa538d524 
> 
> Diff: https://git.reviewboard.kde.org/r/124534/diff/
> 
> 
> Testing
> -------
> 
> Logged out and back in many times :)
> 
> My autostart folder got copied correctly, including symlinks
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150730/c33af461/attachment-0001.html>