AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

[David Edmundson]

Hey, sorry for not replying.

5.4 is being frozen soon, so lets consider this 5.5 material, so we don't
have to rush.

In general, I like it, I have some comments.

I'm a bit concerned by the blocking calls in AccountsService here:
https://github.com/hawaii-desktop/qtaccountsservice/blob/master/src/accountsservice/accountsmanager.cpp#L107

That has the potential to lock up the entire plasma workspace session;
which obviously isn't ideal.
Blocking calls are a problem if we can't rely on the remote service
/always/ behaving.

--

In here:
http://quickgit.kde.org/?p=plasma-workspace.git&a=blobdiff&h=3fa23fc71131c239201bec7e7841455d3c5e5a2c&hp=b500ba44c2b483d7372ca46840152c90ef5f798c&hb=1f308546910b1e3e63542bb1982778755e8ff99d&f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgreeterapp.cpp

we're using QtAccounts for the icon, but KUser for the name. That's a bit
weird.

--

What's this for:
http://quickgit.kde.org/?p=plasma-workspace.git&a=blobdiff&h=a4888cef5415d09e36f594080e4f1d1103b896ec&hp=3fa23fc71131c239201bec7e7841455d3c5e5a2c&hb=58091b95fae55fcc96e95a28599df05130a64bb6&f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgreeterapp.cpp

AccountsService will also search ~/.face.icon, so I can't imagine this
doing anything.

---

We have some code in KDeclarative that returns a user, wrapping kuser. I
don't want to have code in our lib that does one thing, and have our shell
code doing another.


David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150729/54ce03c0/attachment.html>