Review Request 124509: Use small button for session combo

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124509/#review83107
-----------------------------------------------------------


+1, LGTM


lookandfeel/contents/loginmanager/Main.qml (lines 187 - 188)
<https://git.reviewboard.kde.org/r/124509/#comment57383>

    I understand from the comment that it's a HACK, I don't understand from the comment how is the hack supposed to "fix" it. Might be worth adding like three words in the spirit of "becuase this property does that"?


- Martin Klapetek


On July 28, 2015, 3:41 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124509/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 3:41 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> As discussed with the VDG since it's a more of a power user feature
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/loginmanager/Main.qml 065a115 
> 
> Diff: https://git.reviewboard.kde.org/r/124509/diff/
> 
> 
> Testing
> -------
> 
> Work, I had to employ a hack to make the button stay square, and also ComboBox doesn't have a public API to open the popup. I tried using Plasma Menu but it doesn't support exclusive group and the QQC Menu cannot be told where it should open other than the mouse position (also why is the text field not the same height as the login button?)
> 
> 
> File Attachments
> ----------------
> 
> Login screen
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150728/8ac43def/attachment.html>