Review Request 124453: [digital-clock] Provide a simple option for 24h clock

[Thomas Pfeiffer]

> On July 26, 2015, 12:35 a.m., Thomas Pfeiffer wrote:
> > I fully agree with you, in both that this should only be a temporary workaround, and on that it is very helpful as such.
> > +1 from me!
> 
> Martin Klapetek wrote:
>     What's your take on Kai's comment about using a combobox for the options? Currently it is a single checkbox, see the screenshot at [1]. I think you either want to use 24h or you want to use 12h clock and I think that one does not change locales that offten to warrant a "system default", a combo imho is then a needless clutter to the settings dialog. Comments?
>     
>     [1] https://lh5.googleusercontent.com/-riysQFXKRfs/VbJqhhB8yBI/AAAAAAAAT4U/Zy205nGVXF0/w904-h574-no/digital-clock-5_4.png

I agree with Martin: Locale isn't likely to change so often, so I don't think it's much of an annoyance to have to adapt the setting to your liking each time you change the locale.
I'd default it the the one the locale chooses and then allow users to change it manually, period.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124453/#review82967
-----------------------------------------------------------


On July 25, 2015, 9:55 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124453/
> -----------------------------------------------------------
> 
> (Updated July 25, 2015, 9:55 p.m.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Bugs: 345378
>     https://bugs.kde.org/show_bug.cgi?id=345378
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is _the_ most requested feature for the clock, simple checkbox for 24h clock.
> 
> In my opinion this is just a temporary workaround and not a very good one (generally,
> code-wise it's awesome :P). There should really be a global config option for that
> but as we now rely on QLocale and QLocale is...bad at this, here's at least this
> small help, which will at least change the clock format on the panel.
> 
> Imo we could really really use something like KLocale again.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/config/main.xml 8b0872b 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 9506078 
>   applets/digital-clock/package/contents/ui/configAppearance.qml ead0ad5 
> 
> Diff: https://git.reviewboard.kde.org/r/124453/diff/
> 
> 
> Testing
> -------
> 
> Switching the checkbox on and off works as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150728/9ddb38ef/attachment.html>