Review Request 124485: Add missing traffic monitor

Jan Grulich jgrulich at redhat.com
Mon Jul 27 11:15:39 UTC 2015



> On Čec. 27, 2015, 11:12 dop., David Edmundson wrote:
> > applet/contents/ui/ConnectionItem.qml, line 292
> > <https://git.reviewboard.kde.org/r/124485/diff/1/?file=388017#file388017line292>
> >
> >     I don't get why 5?

Because there are 5 lines in the plotter.


> On Čec. 27, 2015, 11:12 dop., David Edmundson wrote:
> > applet/contents/ui/ConnectionItem.qml, line 519
> > <https://git.reviewboard.kde.org/r/124485/diff/1/?file=388017#file388017line519>
> >
> >     can you document this?

Actually I can't, I just copied this part from the system monitor applet, but it just generates the second color used for upload.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124485/#review83030
-----------------------------------------------------------


On Čec. 27, 2015, 10:55 dop., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124485/
> -----------------------------------------------------------
> 
> (Updated Čec. 27, 2015, 10:55 dop.)
> 
> 
> Review request for Network Management, Plasma and KDE Usability.
> 
> 
> Bugs: 333070
>     http://bugs.kde.org/show_bug.cgi?id=333070
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ConnectionItem.qml ff722a7 
> 
> Diff: https://git.reviewboard.kde.org/r/124485/diff/
> 
> 
> Testing
> -------
> 
> ![Traffic monitor](https://jgrulich.fedorapeople.org/plotter.png)
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150727/65560572/attachment-0001.html>


More information about the Plasma-devel mailing list