Review Request 124472: WIP: Implement drag and drop support for icon widget

[Marco Martin]

> On July 26, 2015, 10:46 a.m., Bhushan Shah wrote:
> > applets/icon/plugin/icon_p.cpp, line 106
> > <https://git.reviewboard.kde.org/r/124472/diff/1/?file=387834#file387834line106>
> >
> >     IMO it would make sense to open dropped urls only if it is supported by application..
> >     
> >     like only accept text files on kate and not image files.

checking the mime supported byt the app makes sense.
it would need more C++ bindings to look at the desktop file of the app


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124472/#review82986
-----------------------------------------------------------


On July 26, 2015, 10:40 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124472/
> -----------------------------------------------------------
> 
> (Updated July 26, 2015, 10:40 a.m.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Brings back the ability to drop files onto a icon widget and have the associated application open it. Dropping something onto a folder does not yet work because it should use the konq menu thingie (Copy/Move/Link) but I don't want yet another copy of that (there's one in the folderview containment).
> 
> It should probably check already on drag enter whether it's a viable drop target (eg. executable or folder), also do some coding style cleanups I thought I had already committed earlier.
> 
> 
> Diffs
> -----
> 
>   applets/icon/package/contents/ui/main.qml e0e1df7 
>   applets/icon/plugin/icon_p.h ba2d9f7 
>   applets/icon/plugin/icon_p.cpp 18806fc 
> 
> Diff: https://git.reviewboard.kde.org/r/124472/diff/
> 
> 
> Testing
> -------
> 
> Dragged Gwenview onto the desktop, an icon was created.
> Dropped one picture onto it, Gwenview opened it.
> Dropped two pictures onto, Gwenview showed both.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150727/ac64f1b3/attachment-0001.html>