Review Request 124481: [Panel] Fix min/max size sliderhandles

Marco Martin notmart at gmail.com
Mon Jul 27 09:17:22 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124481/#review83022
-----------------------------------------------------------

Ship it!


yes, the more detailed the better for commit messages

- Marco Martin


On July 26, 2015, 10:14 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124481/
> -----------------------------------------------------------
> 
> (Updated July 26, 2015, 10:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The x (or y) position to value calculation differed from the
> value to x (or y) calulation.
> This lead to strange behavior if the sliders were moved slowly (only
> when panel alignment is center): Though the mouse was moved slowly,
> the sliders moved very fast, sometimes even in the opposide direction.
> 
> Can I use this as a commit message or is it too verbose?
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml 5e8f0c42c076349e7889eeac2d1de69de40b15d5 
> 
> Diff: https://git.reviewboard.kde.org/r/124481/diff/
> 
> 
> Testing
> -------
> 
> Changing the panel size (min- and maximum size) works well in all alignments.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150727/5a8f9e50/attachment.html>


More information about the Plasma-devel mailing list