Review Request 124463: Disable devicePixelRatio in PlasmaShell

[Mark Gaiser]

On jul 25, 2015, 7:38 p.m., David Edmundson wrote:
> > Quote:
> > -- It's also not a /huge/ deal as we do our own thing anyway, so the
> > -- experience is better to just turn off this scaling.
> > 
> > I find that excuse somewhat weak. Sure, Qt's way of scaling is biting now, but that's _becasue_ plasma had to make it's own way of scaling. Sure, i know the reasons why it was done and it was the best choice back then, but from day 1 it was known to become an issue if Qt was also going to support scaling. Which it obviously did since it has to keep up with modern day standards.
> > 
> > Plasma now is in the weird position where it needs to either adapt it's scaling to not conflict with Qt or throw all the custom scaling code away and start using the Qt way. Neither is easy imho.
> 
> David Edmundson wrote:
>     I would say "we would just turn it off" but we have a few places where we draw not using plasma components; but via QWidgets such as Menus, Dialogs, and some of the QQC stuff; and that's where we have problems.
>     
>     In later Qt we should have a way to say "I'll do my own scaling kthnxbye" *per window*, which I think is the ultimate long term solution.
> 
> Martin Klapetek wrote:
>     Do note that Plasma itself works rather fine with QT_DEVICE_PIXEL_RATIO > 1, there are only those three small~ish issues (so not that much adapting needed, as you claim) and definitely there's no conflict in the scalings. There is not that much time to investigate and fix all of those properly before 5.4. Using Plasma without QT_DEVICE_PIXEL_RATIO currently gives great results on hidpi (running it myself), so I do believe that it is better to temporarily disable it for the 5.4 release and revert once those issues are gone.

Martin, those 3 are just the ones reported. I bet there are tens more if you really look for it. I luckaly don't have a highdpi display since i'm extremely nitpicking when it comes to small details being off :) In my experience the "small-ish" bugs are usually the most difficult ones to fix. You can get the vast majority working quite well rather fast (which is where plasma is right now). That last mile is where you don't see much progress (as a user) but will spend many hours (as developer) in trying to figure out where the bug is exactly and fix that.

I could be very wrong, my experience is based on my work environment. The "small" issues take up a big chunk of the total development time.

Anyway (forgot it before) +1.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124463/#review82958
-----------------------------------------------------------


On jul 25, 2015, 4:46 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124463/
> -----------------------------------------------------------
> 
> (Updated jul 25, 2015, 4:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Devive pixel ratio has some problems in plasmashell currently.
> 
> In particular:
> - dialog continually expands (347951)
> - Text element text is screwed (QTBUG-42606)
> - Panel struts (350614)
> 
> It's also not a /huge/ deal as we do our own thing anyway, so the
> experience is better to just turn off this scaling.
> 
> I've had this patch in my local code since forever. 
> 
> We should revert this
> when all 3 are fixed. 
> 
> I'm not willing to currently spend my effort whilst we still have that Qt bug blocking this; but I want to enable the setting for apps in 5.4
> 
> CCBUG: 347951
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp 5c5a5cabb5cac8b3fca063185a82582b187e434e 
> 
> Diff: https://git.reviewboard.kde.org/r/124463/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150725/deee5053/attachment-0001.html>