Review Request 124463: Disable devicePixelRatio in PlasmaShell

Martin Klapetek martin.klapetek at gmail.com
Sat Jul 25 20:24:30 UTC 2015



> On July 25, 2015, 10:24 p.m., Martin Klapetek wrote:
> > +1, I've been running this patch since forever as well on my hidpi laptop, there are no issues without it as far as I can say.

Err, meant just +1, not ship it but oh well.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124463/#review82961
-----------------------------------------------------------


On July 25, 2015, 6:46 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124463/
> -----------------------------------------------------------
> 
> (Updated July 25, 2015, 6:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Devive pixel ratio has some problems in plasmashell currently.
> 
> In particular:
> - dialog continually expands (347951)
> - Text element text is screwed (QTBUG-42606)
> - Panel struts (350614)
> 
> It's also not a /huge/ deal as we do our own thing anyway, so the
> experience is better to just turn off this scaling.
> 
> I've had this patch in my local code since forever. 
> 
> We should revert this
> when all 3 are fixed. 
> 
> I'm not willing to currently spend my effort whilst we still have that Qt bug blocking this; but I want to enable the setting for apps in 5.4
> 
> CCBUG: 347951
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp 5c5a5cabb5cac8b3fca063185a82582b187e434e 
> 
> Diff: https://git.reviewboard.kde.org/r/124463/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150725/71a00069/attachment.html>


More information about the Plasma-devel mailing list