Review Request 124463: Disable devicePixelRatio in PlasmaShell

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124463/#review82958
-----------------------------------------------------------



shell/main.cpp (line 42)
<https://git.reviewboard.kde.org/r/124463/#comment57254>

    You should put heavy documentation around this line to explain why you do that. Even if this hack is short lived and reverted in a few months.
    
    Basically just paste the description of this rr above that line.


Quote:
-- It's also not a /huge/ deal as we do our own thing anyway, so the
-- experience is better to just turn off this scaling.

I find that excuse somewhat weak. Sure, Qt's way of scaling is biting now, but that's _becasue_ plasma had to make it's own way of scaling. Sure, i know the reasons why it was done and it was the best choice back then, but from day 1 it was known to become an issue if Qt was also going to support scaling. Which it obviously did since it has to keep up with modern day standards.

Plasma now is in the weird position where it needs to either adapt it's scaling to not conflict with Qt or throw all the custom scaling code away and start using the Qt way. Neither is easy imho.

- Mark Gaiser


On jul 25, 2015, 4:46 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124463/
> -----------------------------------------------------------
> 
> (Updated jul 25, 2015, 4:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Devive pixel ratio has some problems in plasmashell currently.
> 
> In particular:
> - dialog continually expands (347951)
> - Text element text is screwed (QTBUG-42606)
> - Panel struts (350614)
> 
> It's also not a /huge/ deal as we do our own thing anyway, so the
> experience is better to just turn off this scaling.
> 
> I've had this patch in my local code since forever. 
> 
> We should revert this
> when all 3 are fixed. 
> 
> I'm not willing to currently spend my effort whilst we still have that Qt bug blocking this; but I want to enable the setting for apps in 5.4
> 
> CCBUG: 347951
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp 5c5a5cabb5cac8b3fca063185a82582b187e434e 
> 
> Diff: https://git.reviewboard.kde.org/r/124463/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150725/057fced3/attachment.html>