Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button
Jan Grulich
jgrulich at redhat.com
Sat Jul 25 11:33:49 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------
(Updated July 25, 2015, 11:33 a.m.)
Status
------
This change has been marked as submitted.
Review request for Network Management and Plasma.
Changes
-------
Submitted with commit f1ae6f60769876e5f7ddc0c710f5dec9f862a6e6 by Jan Grulich to branch master.
Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905
Repository: plasma-nm
Description
-------
Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352
Diff: https://git.reviewboard.kde.org/r/124314/diff/
Testing
-------
Thanks,
Jan Grulich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150725/8c38f10a/attachment.html>
More information about the Plasma-devel
mailing list