Review Request 124451: [digital-clock] Add support for ISO date format

Martin Klapetek martin.klapetek at gmail.com
Sat Jul 25 08:38:13 UTC 2015



> On July 25, 2015, 10:37 a.m., Kai Uwe Broulik wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 58-60
> > <https://git.reviewboard.kde.org/r/124451/diff/2/?file=387181#file387181line58>
> >
> >     So in the onDateFormatChange handler you override that very property?

Ah no, that's from an older patch, that whole block shouldn't be there at all.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124451/#review82924
-----------------------------------------------------------


On July 24, 2015, 2:27 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124451/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 2:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Another frequently requested feature - allow date to be displayed
> in ISO format (YYYY-MM-DD)
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 9506078 
>   applets/digital-clock/package/contents/ui/configAppearance.qml ead0ad5 
>   applets/digital-clock/package/contents/ui/main.qml f42d7ad 
> 
> Diff: https://git.reviewboard.kde.org/r/124451/diff/
> 
> 
> Testing
> -------
> 
> ISO date appears as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150725/caf5a353/attachment-0001.html>


More information about the Plasma-devel mailing list