Review Request 124453: [digital-clock] Provide a simple option for 24h clock

[Martin Klapetek]

> On July 24, 2015, 6:46 p.m., David Edmundson wrote:
> > applets/digital-clock/package/contents/ui/configAppearance.qml, line 91
> > <https://git.reviewboard.kde.org/r/124453/diff/3/?file=387247#file387247line91>
> >
> >     am I right that this will be
> >     
> >     checkbox on: 24 hours clock
> >     checkbox off: maybe 12, maybe 24 hour clock depending on your locale
> >     
> >     ?
> 
> Martin Klapetek wrote:
>     No, it will in fact follow the setting regardless of locale (see line 382 in the diff). However, it would be good to make the default the same as the locale (currently it defaults to am/pm).

(note that QLocale switches the 24h/12h automatically according to the presence of "ap" or "AP" in the format string)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124453/#review82908
-----------------------------------------------------------


On July 24, 2015, 4:40 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124453/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 4:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 345378
>     https://bugs.kde.org/show_bug.cgi?id=345378
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is _the_ most requested feature for the clock, simple checkbox for 24h clock.
> 
> In my opinion this is just a temporary workaround and not a very good one (generally,
> code-wise it's awesome :P). There should really be a global config option for that
> but as we now rely on QLocale and QLocale is...bad at this, here's at least this
> small help, which will at least change the clock format on the panel.
> 
> Imo we could really really use something like KLocale again.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/config/main.xml 8b0872b 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 9506078 
>   applets/digital-clock/package/contents/ui/configAppearance.qml ead0ad5 
> 
> Diff: https://git.reviewboard.kde.org/r/124453/diff/
> 
> 
> Testing
> -------
> 
> Switching the checkbox on and off works as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150724/edc19fc2/attachment.html>