Review Request 124415: Don't crash when OSD QML file is invalid
Martin Klapetek
martin.klapetek at gmail.com
Fri Jul 24 13:35:39 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124415/#review82889
-----------------------------------------------------------
Ship it!
shell/osd.cpp (line 131)
<https://git.reviewboard.kde.org/r/124415/#comment57189>
"...OSD QML file" might be more understoodtable but...up to you
- Martin Klapetek
On July 24, 2015, 3:34 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124415/
> -----------------------------------------------------------
>
> (Updated July 24, 2015, 3:34 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Added a syntax error to my osd.qml, Plasma would no longer crash, neither on startup, nor when the OSD should be shown.
>
>
> Diffs
> -----
>
> shell/osd.cpp 3e8bd70
>
> Diff: https://git.reviewboard.kde.org/r/124415/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150724/632b12c4/attachment-0001.html>
More information about the Plasma-devel
mailing list