Review Request 124434: [Panel] Delay disappearance of panel configuration bar on focus lost

[David Kahles]

> On July 24, 2015, 1:25 a.m., David Edmundson wrote:
> > the panel doesn't currently hide when the mouse leaves, only when another window gets focus.
> > 
> > Do you have focus follows mouse set?
> 
> David Kahles wrote:
>     Yes I have, without focus follows mouse it works as expected, I didn't think about that. Is this something we don't fix?
> 
> David Edmundson wrote:
>     ah cool, it explains the different behaviour.
>     
>     >Is this something we don't fix?
>     
>     I don't know, I don't think we want to change the normal experience for this one edge-case. If you explicitly click on another window, there's no reason to make this delay closing.
>     
>     On the other hand, if we are going to provide an option to do a thing we should damn well actually support it.
>     
>     Does kwin expose if the user has focus follows mouse (we have a similar bug with the add widgets dialog and this option) ? 
>     If so can we come up with a good compromise that doesn't complicate code too much?

> I don't know, I don't think we want to change the normal experience for this one edge-case
[snip] if we are going to provide an option to do a thing we should damn well actually support it.

I fully agree to both statements. There are multiple bug reports about this/smimilar problems. In bug [1] Martin Gräßlin said
> We could alter the behavior of the add widget dialog by allowing Plasma to query KWin's focus policy, but I would not recommend to go that road.

Martin: Could you explain why you wouldn't do this?

[1] https://bugs.kde.org/show_bug.cgi?id=262835#c8


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124434/#review82849
-----------------------------------------------------------


On July 24, 2015, 11:51 a.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124434/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 11:51 a.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Wait (per default) 600ms to hide the panelconfigview, because
> sometimes it happens that a user inadvertently leaves
> the panelconfigview with his mouse.
> Then he/she has to reopen the panelconfigview because it hides
> immediately. 600ms should be long enought to move the mouse back into
> the panelconfgview and prevent the hide.
> 
> 
> Diffs
> -----
> 
>   shell/panelconfigview.h 98705d13875c92acdc46355f600ce8541e4596f4 
>   shell/panelconfigview.cpp dee2acc8618bf6341de1427dc18c2a2a00463c15 
> 
> Diff: https://git.reviewboard.kde.org/r/124434/diff/
> 
> 
> Testing
> -------
> 
> Using the panel configuration bar works much better now as it doesn't hide immediately.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150724/b3767b53/attachment-0001.html>