Review Request 124415: Don't crash when OSD QML file is invalid

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124415/#review82787
-----------------------------------------------------------

Ship it!



shell/osd.cpp (lines 146 - 148)
<https://git.reviewboard.kde.org/r/124415/#comment57101>

    I think it might be useful to have a qWarning here too? You may miss it in the plasma startup output but then when actually triggering the osd it would print again (and again) so you'd actually get some feedback while testing the osd.


- Martin Klapetek


On July 21, 2015, 10:39 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124415/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 10:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Added a syntax error to my osd.qml, Plasma would no longer crash, neither on startup, nor when the OSD should be shown.
> 
> 
> Diffs
> -----
> 
>   shell/osd.cpp 3e8bd70 
> 
> Diff: https://git.reviewboard.kde.org/r/124415/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150721/0f59dd8b/attachment.html>