Review Request 124374: custom inline edit menu for plasma controls

[Andrew Lake]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/#review82771
-----------------------------------------------------------


Very nice. A couple questions:
1. Are the inline selectiion handles grab-able? I assume yes.
2. Does this automatically appear when a selection is made or on right-click? I assume the former.

It would eventually be nice to have this solution for main application controls as well (or at least QtQuick controls)

Anyway, quite nice.

- Andrew Lake


On July 21, 2015, 9:35 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124374/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 9:35 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This depends from https://codereview.qt-project.org/#/c/121659/
> provides the needed elements for touch based text selection and inline (no separate window) menu for cut/copy/paste
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
>   src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 
> 
> Diff: https://git.reviewboard.kde.org/r/124374/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> snapshot1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150721/7aa81051/attachment.html>