Review Request 124409: Begin fading the OSD immediately

Martin Klapetek martin.klapetek at gmail.com
Tue Jul 21 07:55:05 UTC 2015



> On July 21, 2015, 1:36 a.m., Aleix Pol Gonzalez wrote:
> > lookandfeel/contents/osd/Osd.qml, line 48
> > <https://git.reviewboard.kde.org/r/124409/diff/1/?file=386441#file386441line48>
> >
> >     This looks like a random wait time... Looking at the video, it seems like a slow animation.
> >     Is it intended?

Yes. The idea is show and immediately start fading out which is perceived as "it's hiding already" (as opposed to showing for 2 seconds and doing nothing) but it's hiding slow enough to register the values/read the text.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124409/#review82738
-----------------------------------------------------------


On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124409/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 10:19 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/osd/Osd.qml 2288ec1 
>   shell/osd.cpp 0573d51 
> 
> Diff: https://git.reviewboard.kde.org/r/124409/diff/
> 
> 
> Testing
> -------
> 
> Works. Quite enjoyable. As suggested by mklapetek
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150721/47f71914/attachment.html>


More information about the Plasma-devel mailing list