Review Request 124395: Test if signals are defined before using them

Scott Kitterman kde at kitterman.com
Sun Jul 19 18:03:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124395/#review82660
-----------------------------------------------------------


Looks good to me.

- Scott Kitterman


On July 19, 2015, 5:47 p.m., Felix Geyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124395/
> -----------------------------------------------------------
> 
> (Updated July 19, 2015, 5:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> killtest.cpp sends various signals for testing.
> Not all of them are defined on all architectures.
> Guard those with #ifdef
> 
> Example (mipsel):
> https://buildd.debian.org/status/fetch.php?pkg=plasma-workspace&arch=mipsel&ver=4%3A5.3.2-2&stamp=1437262916
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/autotests/killtest.cpp 2e9997f 
> 
> Diff: https://git.reviewboard.kde.org/r/124395/diff/
> 
> 
> Testing
> -------
> 
> plasma-workspace built fine with this patch on mipsel.
> 
> 
> Thanks,
> 
> Felix Geyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150719/f95df0c1/attachment.html>


More information about the Plasma-devel mailing list