Review Request 124397: Add today button to calendar

[Bernhard Friedreich]

> On Juli 19, 2015, 4:50 nachm., Kai Uwe Broulik wrote:
> > Please include a screenshot for UI changes.
> > 
> > Also please wait until Review 122488 is merged to save me another rebase headache.

Of course :) I'll wait till your Review is merged. Just wanted to get some comments if I'm on the right track :)

Thanks for the review :) Screenshot attached.


> On Juli 19, 2015, 4:50 nachm., Kai Uwe Broulik wrote:
> > src/declarativeimports/calendar/qml/MonthView.qml, lines 161-164
> > <https://git.reviewboard.kde.org/r/124397/diff/1/?file=386074#file386074line161>
> >
> >     ToolButton has a tooltip property, no need for a custom tooltip

thanks didn't know that :) in the original code it was done like this.


> On Juli 19, 2015, 4:50 nachm., Kai Uwe Broulik wrote:
> > src/declarativeimports/calendar/qml/MonthView.qml, line 156
> > <https://git.reviewboard.kde.org/r/124397/diff/1/?file=386074#file386074line156>
> >
> >     ToolButton is square by default

makes sense..


> On Juli 19, 2015, 4:50 nachm., Kai Uwe Broulik wrote:
> > src/declarativeimports/calendar/qml/MonthView.qml, line 155
> > <https://git.reviewboard.kde.org/r/124397/diff/1/?file=386074#file386074line155>
> >
> >     Should be "go-jump-today" I suppose

fixed thanks :)


- Bernhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124397/#review82653
-----------------------------------------------------------


On Juli 19, 2015, 5:04 nachm., Bernhard Friedreich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124397/
> -----------------------------------------------------------
> 
> (Updated Juli 19, 2015, 5:04 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 348362
>     http://bugs.kde.org/show_bug.cgi?id=348362
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add button "Select Today" to calendar title bar, aligned to the right
> Removed commented out code to jump to a specific date, this will likely
> be replaced by RR 122488
> 
> BUG: 348362
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/qml/MonthView.qml 601755f4e9f99618914099e35616e71c332ec7c4 
> 
> Diff: https://git.reviewboard.kde.org/r/124397/diff/
> 
> 
> Testing
> -------
> 
> plasmoidviewer with digitalclock plasmoid
> added digitalclock plasmoid to desktop
> 
> clicked digital clock plasmoid to view calendar
> "Select Today" button is shown
> clicked different day
> clicked button -> jumps to today
> moved to another month -> clicked button --> jumps to today
> 
> 
> File Attachments
> ----------------
> 
> Plasmoidviewer Digital Clock showing Calendar with Today ToolButton
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150719/248b8f76/attachment-0001.html>