Review Request 124394: Timer: trying to fix missing translation in config file (not working)

Kai Uwe Broulik kde at privat.broulik.de
Sun Jul 19 16:51:48 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124394/#review82655
-----------------------------------------------------------


What about just leaving the default an empty string and then do a fallback on the QML side?

- Kai Uwe Broulik


On Juli 19, 2015, 2:25 nachm., Bernhard Friedreich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124394/
> -----------------------------------------------------------
> 
> (Updated Juli 19, 2015, 2:25 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 347492
>     http://bugs.kde.org/show_bug.cgi?id=347492
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> I'm trying to fix a missing translation in the timer applets config file (config.xml using kcfg) but I can't get it to work :(
> 
> David Edmundson commented in the bug if this fixed it - I don't think so - or at least I don't understand what to do with it..
> https://git.reviewboard.kde.org/r/123872/
> 
> Any suggestions?
> 
> 
> Diffs
> -----
> 
>   applets/timer/package/contents/config/main.xml 833bf8f45df4f0e468301a426852bf01c94e1221 
> 
> Diff: https://git.reviewboard.kde.org/r/124394/diff/
> 
> 
> Testing
> -------
> 
> Tried adding the applet - the full i18n String is used instead of a translation/the original string
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150719/bce4fbea/attachment.html>


More information about the Plasma-devel mailing list