Review Request 123557: FindQalculate: Use FindPkgConfig instead of UsePkgConfig

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123557/#review82593
-----------------------------------------------------------



cmake/FindQalculate.cmake (line 25)
<https://git.reviewboard.kde.org/r/123557/#comment56955>

    this is weird, shouldn't it be find_package(PkgConfig)?



cmake/FindQalculate.cmake (line 37)
<https://git.reviewboard.kde.org/r/123557/#comment56956>

    endif()



cmake/FindQalculate.cmake (line 39)
<https://git.reviewboard.kde.org/r/123557/#comment56957>

    Shouldn't pkgconfig give us that?


- Aleix Pol Gonzalez


On April 29, 2015, 2 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123557/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 2 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The latter is deprecated and doesn't respect the PKG_CONFIG
> environment variable which makes it easy to deal with differently
> named pkg-config executables, e.g. arch-prefixed ones.
> 
> 
> Diffs
> -----
> 
>   cmake/FindQalculate.cmake 707a9f7c96b16daf18c1b75400eb8ac4dd30da2c 
> 
> Diff: https://git.reviewboard.kde.org/r/123557/diff/
> 
> 
> Testing
> -------
> 
> Configured, built and checked that plasma-workspace links to qualculate and cln.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150716/13262f91/attachment.html>