Review Request 124374: custom inline edit menu for plasma controls

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/#review82573
-----------------------------------------------------------



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 40)
<https://git.reviewboard.kde.org/r/124374/#comment56949>

    Urgh, can't you assign that at the end? Repeatedly changing the parent sounds dangerous



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 59)
<https://git.reviewboard.kde.org/r/124374/#comment56946>

    enabled / visible only when there is a selection



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 75)
<https://git.reviewboard.kde.org/r/124374/#comment56947>

    enabled: control.canPaste



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 104)
<https://git.reviewboard.kde.org/r/124374/#comment56948>

    unused



src/declarativeimports/plasmastyle/SelectionHandleStyle.qml (line 33)
<https://git.reviewboard.kde.org/r/124374/#comment56950>

    Oh the wonders of QtQuick Rectangle which cannot to different corner radii


- Kai Uwe Broulik


On Juli 16, 2015, 1:57 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124374/
> -----------------------------------------------------------
> 
> (Updated Juli 16, 2015, 1:57 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This depends from https://codereview.qt-project.org/#/c/121659/
> provides the needed elements for touch based text selection and inline (no separate window) menu for cut/copy/paste
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
>   src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 
> 
> Diff: https://git.reviewboard.kde.org/r/124374/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> snapshot1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150716/50d355b9/attachment.html>