Review Request 124375: Fix potential endless recursion in PanelView::event() handler

Daniel Vrátil dvratil at kde.org
Thu Jul 16 13:48:12 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124375/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-workspace


Description
-------

`PanelView::event()` generates new events for itself and dispatches them via `QCoreApplication::sendEvent()`, which calls the handler directly. This can lead to endless recursion. This patch changes the handler to use `QCoreApplication::postEvent()` instead to enqueue the new event and dispatch it from `QEventLoop` after the current `PanelView::event()` returns.

Downstream bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1226644


Diffs
-----

  shell/panelview.cpp b94673d 

Diff: https://git.reviewboard.kde.org/r/124375/diff/


Testing
-------


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150716/9533a8a1/attachment.html>


More information about the Plasma-devel mailing list