Review Request 124360: [shell] Add Wayland support to PanelShadow

Martin Gräßlin mgraesslin at kde.org
Wed Jul 15 09:27:17 UTC 2015



> On July 15, 2015, 11:01 a.m., Marco Martin wrote:
> > +1
> > code looks pretty clean, considering what it does, deferring +2 to testing after corresponding parts of kwin are pushed/tested
> 
> Martin Gräßlin wrote:
>     kwayland part pushed with http://commits.kde.org/kwayland/6922d5184037ea6f85d173b027c858c5e9d6b3be

And kwin part pushed with http://commits.kde.org/kwin/df1146bfa63de6bebd044161fffbff20e31ba677


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124360/#review82529
-----------------------------------------------------------


On July 15, 2015, 10:53 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124360/
> -----------------------------------------------------------
> 
> (Updated July 15, 2015, 10:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This change adds support for shadows using the KWin specific shadow
> protocol provided by KWayland. The protocol is inspired by the X11
> protocol, so it can be easily integrated. The protocol takes a buffer
> for each of the shadow parts and provides the same offsets.
> 
> To make this possible the code is better split into X11 and Wayland
> specific parts.
> 
> 
> Diffs
> -----
> 
>   shell/panelshadows.cpp c97564a2417a66e17a1a02237155f19addf2b9c7 
> 
> Diff: https://git.reviewboard.kde.org/r/124360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150715/6b00e217/attachment.html>


More information about the Plasma-devel mailing list