Review Request 124360: [shell] Add Wayland support to PanelShadow

Marco Martin notmart at gmail.com
Wed Jul 15 09:01:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124360/#review82529
-----------------------------------------------------------


+1
code looks pretty clean, considering what it does, deferring +2 to testing after corresponding parts of kwin are pushed/tested

- Marco Martin


On July 15, 2015, 8:53 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124360/
> -----------------------------------------------------------
> 
> (Updated July 15, 2015, 8:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This change adds support for shadows using the KWin specific shadow
> protocol provided by KWayland. The protocol is inspired by the X11
> protocol, so it can be easily integrated. The protocol takes a buffer
> for each of the shadow parts and provides the same offsets.
> 
> To make this possible the code is better split into X11 and Wayland
> specific parts.
> 
> 
> Diffs
> -----
> 
>   shell/panelshadows.cpp c97564a2417a66e17a1a02237155f19addf2b9c7 
> 
> Diff: https://git.reviewboard.kde.org/r/124360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150715/c63c69e5/attachment.html>


More information about the Plasma-devel mailing list