Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

[Lamarque Souza]

> On July 14, 2015, 1:11 p.m., Lamarque Souza wrote:
> > applet/contents/ui/PopupDialog.qml, line 68
> > <https://git.reviewboard.kde.org/r/124314/diff/1/?file=383993#file383993line68>
> >
> >     The correct English for this is currentVisibleButtonIndex.
> 
> Jan Grulich wrote:
>     The meaning of this is "current index of visible button".

I thought "current" related to "visible button", like in "current visible button's index" (therefore currentVisibleButtonIndex). That is the same as "index of current visible button". "Current index of visible button" sounds like the visible button can stay the same but its index can change, which is not what happens (there are several buttons, but just one "currently" visible).


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/#review82494
-----------------------------------------------------------


On July 14, 2015, 7:43 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124314/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 7:43 a.m.)
> 
> 
> Review request for Network Management and Plasma.
> 
> 
> Bugs: 348905
>     http://bugs.kde.org/show_bug.cgi?id=348905
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ConnectionItem.qml 3fa93b5 
>   applet/contents/ui/PopupDialog.qml 2a0d352 
> 
> Diff: https://git.reviewboard.kde.org/r/124314/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150714/cc36b205/attachment-0001.html>