Review Request 124340: Use plasma icon for update notifier

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124340/#review82489
-----------------------------------------------------------



notifier/MuonNotifier.cpp (line 113)
<https://git.reviewboard.kde.org/r/124340/#comment56888>

    Where did these come from?


The rest of the patch looks good.

- Aleix Pol Gonzalez


On July 13, 2015, 8:20 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124340/
> -----------------------------------------------------------
> 
> (Updated July 13, 2015, 8:20 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: muon
> 
> 
> Description
> -------
> 
> This makes it use the Plasma theme's icon for the updater.
> 
> 
> Diffs
> -----
> 
>   notifier/MuonNotifier.cpp e3ca913 
>   notifier/plasmoid/contents/ui/main.qml 5e32b24 
> 
> Diff: https://git.reviewboard.kde.org/r/124340/diff/
> 
> 
> Testing
> -------
> 
> Works. I'm not too happy with the icons, though, perhaps VDG should improve them a bit.
> 
> The "no updates" icon isn't really recognizable and looks similar to the notification icon above it. The "there are updates" icon looks sort of okay, the "security updates" icon should perhaps be red/orange so it stands out. There's also a dedicated security updates icon but it has a padlock in it and looks like something has to be unlocked rather than about updates.
> 
> 
> File Attachments
> ----------------
> 
> No updates
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/024917b4-d9ab-4584-bc3a-333d2d47487b__updates-none.png
> Updates available
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/99678ec4-ebb9-49de-93e0-fdb990660fd9__updates-some.png
> Security updates
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/8f641ed9-0012-4384-b3c6-9ac7ea6a1b7e__updates-important.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150714/ef01e4d5/attachment.html>