Review Request 124339: Don't store state in the LayoutManager.js

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124339/
-----------------------------------------------------------

(Updated Juli 13, 2015, 5:57 nachm.)


Status
------

This change has been discarded.


Review request for Plasma.


Bugs: 350157
    https://bugs.kde.org/show_bug.cgi?id=350157


Repository: plasma-desktop


Description
-------

It breaks with our shared engine approach. I'm not really happy with this, it feels a bit like writing C code. Another approach would be to kill the layout manager and dump its functions into the main.qml


Diffs
-----

  containments/panel/contents/code/LayoutManager.js fed32be 
  containments/panel/contents/ui/ConfigOverlay.qml a89a5fe 
  containments/panel/contents/ui/main.qml 1ed0dc2 

Diff: https://git.reviewboard.kde.org/r/124339/diff/


Testing
-------

Added another panel, played around with it a bit, unlocked and locked widgets, seems to work. I will make a patch for Desktop containment too.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150713/b6f8317d/attachment.html>