Review Request 124311: Improve wallpaper rendering

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124311/#review82335
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On July 9, 2015, 8:33 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124311/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 8:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 338506
>     https://bugs.kde.org/show_bug.cgi?id=338506
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Update the targetSize when it changes to ensure when resolution changes, we update the image. Also, since the view initially has a 1024x768 size it would just load that image and never use the full resolution leaving you with an ugly blurry image (used to work at some point though iirc)
> 
> Also don't bother loading anything until everything has settled and the size is the final one. This potentially improves startup performance by saving a bit of IO.
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/image.h 5d297b5 
>   wallpapers/image/image.cpp f5920bf 
> 
> Diff: https://git.reviewboard.kde.org/r/124311/diff/
> 
> 
> Testing
> -------
> 
> At least in Scaled mode I can no longer see a difference between the image opened in Gwenview and on the Desktop. For some reason it still stretches it when I use Scale and Crop although it loads the 2560x1440 image. Changed screen resolution and it loaded a new image.
> 
> That test image in the bug report looks fine to me now. Ok, no, that image doesn't go through that target size thing probably so did not change.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150710/9d55a7d3/attachment-0001.html>