Review Request 124317: Wayland port of ksplashqml

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124317/
-----------------------------------------------------------

(Updated July 10, 2015, 9:30 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Martin Klapetek.


Changes
-------

Submitted with commit 56d2c15b9acb9c4b57398b281685807c3191f622 by Martin Gräßlin to branch master.


Repository: plasma-workspace


Description
-------

On Wayland no window is created with BypassWindowManagerHint. On
platforms != X11 it's better to just set it as fullscreen. This has
the disadvantage that we cannot ensure that the splash stays top of
stack. Might need support from e.g. Wayland compositor.

[ksplashqml] Delay closing stdin, stdout till app is constructed

During app startup eglInitialize on Wayland dead locks if the channels
are closed. So delay till app is constructed.


Diffs
-----

  ksplash/ksplashqml/main.cpp 8ab07c66a4efcec2e027182ff4afd5b28c8fcd71 
  ksplash/ksplashqml/splashwindow.cpp b67ec74ab91d6739a8a7bad64d8cb693393547c9 

Diff: https://git.reviewboard.kde.org/r/124317/diff/


Testing
-------

starting a plasma/wayland session now shows a splash screen. Remind me to live demo that to you during Monday hangout.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150710/ff499a70/attachment.html>