Review Request 124293: Add a startplasmacompositor and startplasma file

[Martin Gräßlin]

> On July 8, 2015, 1:15 p.m., Aleix Pol Gonzalez wrote:
> > startkde/startplasma.cmake, line 109
> > <https://git.reviewboard.kde.org/r/124293/diff/1/?file=383697#file383697line109>
> >
> >     Are you sure this belongs to the script?

yes, it's compatibility for old X world. In startkde it used to be set together with the variables. That's not possible any more as the variables are set before we have X up. So I added the actual xprop commands to the one in plasma


> On July 8, 2015, 1:15 p.m., Aleix Pol Gonzalez wrote:
> > startkde/startplasma.cmake, line 119
> > <https://git.reviewboard.kde.org/r/124293/diff/1/?file=383697#file383697line119>
> >
> >     No better way to display an error message?

I don't know how else to do it.


On July 8, 2015, 1:15 p.m., Martin Gräßlin wrote:
> > I'm not going to oppose, but I cringe at forking this ugliness...

Yes I do agree, but it's the question of getting something fast or investing probably several personmonths of work to get it right.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124293/#review82219
-----------------------------------------------------------


On July 8, 2015, 12:26 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124293/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 12:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Both are basically a fork of startkde split into
> * everything needed before kwin_wayland starts
> * everything which needs to happen after kwin_wayland
> 
> A few things are X11 specific and need to go after kwin_wayland
> gets started.
> 
> 
> Diffs
> -----
> 
>   startkde/CMakeLists.txt 6cc1fa3cc492ca4f8354b17c55a825832a093721 
>   startkde/startplasma.cmake PRE-CREATION 
>   startkde/startplasmacompositor.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124293/diff/
> 
> 
> Testing
> -------
> 
> started a plasma/wayland session on my notebook. There's still the problem that it needs a patched kdeinit with OOM_PROTECT disabled.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150708/c03af9bb/attachment.html>