Review Request 124093: Bug 345405 - Prevent two wallpaper images showing overlayed when "Scaled, Keep Proportions" is chosen

[William Lieurance]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124093/
-----------------------------------------------------------

(Updated July 7, 2015, 4:26 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 6326f09e9b6111a6048f2fc8191f04e8486aaa00 by David Edmundson on behalf of William Lieurance to branch master.


Bugs: 345405
    https://bugs.kde.org/show_bug.cgi?id=345405


Repository: plasma-workspace


Description
-------

Moving the opacity change from a ScriptAction to a parallel OpacityAnimator.  That seems to cause a repaint in whatever weird environment happens to be the root of this bug.


Diffs
-----

  wallpapers/image/imagepackage/contents/ui/main.qml 23d23ff7003488d74ece0d70a1c68d129f282c75 

Diff: https://git.reviewboard.kde.org/r/124093/diff/


Testing
-------

See conversation on the bug page (https://bugs.kde.org/show_bug.cgi?id=345405).  This code should work identically to the current script, but for whatever reason it causes a repaint to be issued correctly whereas the other does not.


Thanks,

William Lieurance

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150707/2b3b63bb/attachment-0001.html>