Review Request 124215: Explicitly look for XKB instead of juggling paths in base of a prefix

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jul 7 14:41:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124215/
-----------------------------------------------------------

(Updated July 7, 2015, 2:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 543652303260945ba0ca0190184d3a72aa4097b7 by Aleix Pol on behalf of Aleix Pol Gonzalez to branch master.


Bugs: 349658
    https://bugs.kde.org/show_bug.cgi?id=349658


Repository: plasma-desktop


Description
-------

Instead of looking for X11 libraries and then looking stuff up, just find the directory we're looking for.
Also drop XBINDIR, as it wasn't being used at all.

Should give something like this directory:
```
$ ls /usr/share/X11/xkb/
compat  geometry  keycodes  rules  symbols  types
```


Diffs
-----

  ConfigureChecks.cmake 4fc4bce 
  config-workspace.h.cmake eda8996 
  kcms/keyboard/xkb_rules.cpp 9fd0324 

Diff: https://git.reviewboard.kde.org/r/124215/diff/


Testing
-------

re-compiled on my system, everything still works.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150707/a3deb3dc/attachment.html>


More information about the Plasma-devel mailing list