Review Request 124280: Only resize plot texture if size actually changes

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jul 7 14:16:11 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124280/#review82176
-----------------------------------------------------------

Ship it!


Makes sense.

- Aleix Pol Gonzalez


On July 7, 2015, 1:02 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124280/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 1:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Test compared rounded QSize with QSizeF, which will be almost always
> returning true.
> 
> CCBUG: 348385
> REVIEW:
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 9a939c3626fc6321a39e898b88e5b69c14b4e1b7 
> 
> Diff: https://git.reviewboard.kde.org/r/124280/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150707/689e650e/attachment.html>


More information about the Plasma-devel mailing list