Review Request 124280: Only resize plot texture if size actually changes

Luca Beltrame lbeltrame at kde.org
Tue Jul 7 12:18:39 UTC 2015



> On Lug. 7, 2015, 12:02 p.m., Luca Beltrame wrote:
> > I can't comment on the code itself, but from my small unscientific test, the CPU usage of the component seems gone.

If that's the case (can anyone else confirm), it should also fix bug 346134.


- Luca


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124280/#review82167
-----------------------------------------------------------


On Lug. 7, 2015, 11:02 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124280/
> -----------------------------------------------------------
> 
> (Updated Lug. 7, 2015, 11:02 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Test compared rounded QSize with QSizeF, which will be almost always
> returning true.
> 
> CCBUG: 348385
> REVIEW:
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 9a939c3626fc6321a39e898b88e5b69c14b4e1b7 
> 
> Diff: https://git.reviewboard.kde.org/r/124280/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150707/d5595d3c/attachment.html>


More information about the Plasma-devel mailing list