Review Request 124270: [kcms/input] Ensure X11 specific code doesn't crash on other platforms

Martin Gräßlin mgraesslin at kde.org
Tue Jul 7 11:42:56 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124270/
-----------------------------------------------------------

(Updated July 7, 2015, 11:42 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 889f640dc6ceaf5e6bf00d116da5a6101cd74043 by Martin Gräßlin to branch master.


Repository: plasma-desktop


Description
-------

For the kcminit_mouse it's important to also function on Xwayland in
order to set correct cursor information for X clients. Thus if it's
not on platform xcb it tries to open an X connection the old way.


Diffs
-----

  kcms/input/main.cpp 9703e793665ca78c2d05f4395199faa6cdf78ff4 
  kcms/input/mouse.h 8ec0a95f5dcb929dff87ace152357e022a5979f6 
  kcms/input/mouse.cpp a190effaad68390b3e3e36405b689a53895c9a98 

Diff: https://git.reviewboard.kde.org/r/124270/diff/


Testing
-------

No longer crashes on Wayland


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150707/1e202c0e/attachment.html>


More information about the Plasma-devel mailing list