Review Request 124269: [kcms/access] Do nothing on non X11 platforms

[Martin Gräßlin]

> On July 6, 2015, 2:35 p.m., Aleix Pol Gonzalez wrote:
> > kcms/access/kaccess.cpp, line 147
> > <https://git.reviewboard.kde.org/r/124269/diff/1/?file=383468#file383468line147>
> >
> >     Initialize with the rest of the members on line 145?

I thought about it and the code in question is just "meh". Some variables are inited in line 145 as you suggest, but more are inited in the ctor body. As the variable might change in the ctor anyway I decided to put it into the ctor.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124269/#review82119
-----------------------------------------------------------


On July 6, 2015, 1:52 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124269/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 1:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Code base is very X11 dependent and crashes on other platforms.
> 
> Checks whether it's not X11 and quits.
> 
> 
> Diffs
> -----
> 
>   kcms/access/kaccess.h b39558e9d5343f10204f54e9d3ff8760f803ac09 
>   kcms/access/kaccess.cpp 4d57824f6025ccdc1e47dfbfcb0973925307bd71 
>   kcms/access/main.cpp a4590bf135bd00eb34fca74753d43f89cabe017a 
> 
> Diff: https://git.reviewboard.kde.org/r/124269/diff/
> 
> 
> Testing
> -------
> 
> No longer crashes on Wayland
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150706/f15463d5/attachment.html>