Review Request 124250: Add screenlocker docbook

[Burkhard Lück]

> On Juli 5, 2015, 12:59 nachm., Martin Gräßlin wrote:
> > This adds a new directory called "kcontrol". Would it not be better to drop this KDE 3.5 term and replace it with what it's about? E.g. "lockscreen" or "screenlocker"?

No, because
1) The new directory called "kcontrol is consistent with nearly all other kcm docbooks (one except is kwin - see 3)
2) Scripty needs the directory "kcontrol" to generate entries with the correct install path for CMakelists.txt in the language docbook directories
3) For the kwin kcm docbooks not beeing in a subdir kcontrol the file http://websvn.kde.org/trunk/l10n-kf5/scripts/documentation_paths?view=markup 
   needs five entries to "add" the necessary kcontrol dir for scripty instead of one entries with kwin kcm docbooks in a subdir kcontrol


- Burkhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124250/#review82091
-----------------------------------------------------------


On Juli 6, 2015, 9:54 vorm., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124250/
> -----------------------------------------------------------
> 
> (Updated Juli 6, 2015, 9:54 vorm.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Add missing screenlocker docbook, a modified copy from kde-workspace / doc / kcontrol / screensaver / index.docbook @ KDE/4.11
> 
> 
> Diffs
> -----
> 
>   doc/CMakeLists.txt 0eb36a6 
>   doc/kcontrol/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/screenlocker/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/screenlocker/index.docbook PRE-CREATION 
>   ksmserver/screenlocker/kcm/screenlocker.desktop 19caa3b 
> 
> Diff: https://git.reviewboard.kde.org/r/124250/diff/
> 
> 
> Testing
> -------
> 
> Builds and is opened an Help Action in KCM
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150706/fd3db3f0/attachment.html>