Review Request 123992: Use upcoming version of libdbusmenu-qt

David Edmundson david at davidedmundson.co.uk
Mon Jul 6 08:55:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123992/
-----------------------------------------------------------

(Updated July 6, 2015, 8:55 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 3d0a9cd462a7ab256b65dec7ed2035e0d7658818 by David Edmundson to branch master.


Repository: plasma-workspace


Description
-------

This contains a temporary fork of the dbusmenu-qt importer, with the main paths fixed. Also fixes some leaks

No loner has a stupid event loop. This fixes ~5 crash reports we've had.

Submitted to upstream, but they're not the fastest and it has to be an API break.


Diffs
-----

  dataengines/statusnotifieritem/CMakeLists.txt e639ee351a1cc6ad0b4448bd0feadc7af0d7984d 
  dataengines/statusnotifieritem/libdbusmenuqt/README PRE-CREATION 
  dataengines/statusnotifieritem/libdbusmenuqt/dbusmenuimporter.h PRE-CREATION 
  dataengines/statusnotifieritem/libdbusmenuqt/dbusmenuimporter.cpp PRE-CREATION 
  dataengines/statusnotifieritem/libdbusmenuqt/dbusmenushortcut_p.h PRE-CREATION 
  dataengines/statusnotifieritem/libdbusmenuqt/dbusmenushortcut_p.cpp PRE-CREATION 
  dataengines/statusnotifieritem/libdbusmenuqt/dbusmenutypes_p.h PRE-CREATION 
  dataengines/statusnotifieritem/libdbusmenuqt/dbusmenutypes_p.cpp PRE-CREATION 
  dataengines/statusnotifieritem/libdbusmenuqt/utils.cpp PRE-CREATION 
  dataengines/statusnotifieritem/libdbusmenuqt/utils_p.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123992/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150706/0dcdd802/attachment.html>


More information about the Plasma-devel mailing list